Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update packages #383

Closed
wants to merge 10 commits into from
Closed

update packages #383

wants to merge 10 commits into from

Conversation

tikicoder
Copy link

code updates to support package updates

@tikicoder tikicoder mentioned this pull request Sep 19, 2020
@alexwaibel
Copy link
Collaborator

Thank you for submitting this PR. Could you elaborate a bit further on the code changes and why they're necessary to update the vulnerable NPM packages? I agree that it is worth upgrading the packages if we can, it just seems there are many unrelated changes included.

This project also follows the poorly named JavaScript Standard Style and from a quick glance it appears there are some formatting issues with your code that will not pass the CICD. Before this can be merged, these style inconsistencies will need to be addressed.

@tikicoder
Copy link
Author

I was unaware of the standard. The updates were required after I updated as the code no longer worked for me without modifications. I could have been maybe overzealous but I tried to take out the items I did specifically for my build. I know one of the changes was to support the changes in the API around Recaptcha and support v2 and v3 captcha. I would have to know what changes you are referring to, to comment on why it was done.

@alexwaibel
Copy link
Collaborator

Closing this as I believe my recent changes in #396 and #397 covered upgrading the key dependencies to their latest version. Feel free to comment here if you think anything was missed and needs addressed.

@alexwaibel alexwaibel closed this Dec 6, 2020
@datapolitical
Copy link

I need v3 support @alexwaibel so I would love to see this PR accepted.

@tikicoder tikicoder deleted the master branch July 1, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants